-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Guild): add disableInvites method #8801
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Not sure I agree with this. Managers possess the relevant API methods. Altering a guild's features should not be on this manager. |
Codecov Report
@@ Coverage Diff @@
## main #8801 +/- ##
===========================================
+ Coverage 58.75% 85.61% +26.85%
===========================================
Files 11 96 +85
Lines 1593 9459 +7866
Branches 90 1134 +1044
===========================================
+ Hits 936 8098 +7162
- Misses 656 1319 +663
- Partials 1 42 +41
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Agree with Jira, helper methods conventionally belong on structures, not managers. If this were to exist somewhere, a helper method to modify a GuildFeature would belong on the Guild class, e.g. |
Doesn't |
Since the feature is called Invites Disabled, it makes more sense to call it |
Co-authored-by: Hackerboi 69 <62872992+thehackerboi69github@users.noreply.github.com>
Discord faq named it pausing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind if the method ends up being named disableInvites
or pauseInvites
(although the latter has the issue about being a bit weird to "resume" using a "pause" method).
Regardless of that, we use API names rather than client names, that's why we use "guild" rather than "server", for example.
a bit like that |
Please describe the changes this PR makes and why it should be merged:
This PR adds a
disableInvites
method toGuild
as a helper to disable/pause invitesStatus and versioning classification: