Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ForumChannel): add defaultForumLayout #8895

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Dec 1, 2022

Please describe the changes this PR makes and why it should be merged:
Upstream:

Depends on:

Status and versioning classification:

  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Dec 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Dec 16, 2022 at 1:19PM (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Dec 16, 2022 at 1:19PM (UTC)

@almeidx almeidx force-pushed the discord.js/forum-default-layout branch from 9d0c53a to 392e315 Compare December 15, 2022 15:47
@almeidx almeidx marked this pull request as ready for review December 15, 2022 15:47
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #8895 (43a5c40) into main (e470e08) will increase coverage by 6.69%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8895      +/-   ##
==========================================
+ Coverage   77.66%   84.35%   +6.69%     
==========================================
  Files          24       98      +74     
  Lines        3837     9180    +5343     
  Branches      348     1096     +748     
==========================================
+ Hits         2980     7744    +4764     
- Misses        853     1394     +541     
- Partials        4       42      +38     
Flag Coverage Δ
brokers 65.24% <ø> (?)
builders 98.22% <ø> (?)
collection 100.00% <ø> (?)
proxy 77.37% <ø> (ø)
rest 91.97% <ø> (ø)
util 100.00% <ø> (?)
utilities 100.00% <ø> (?)
voice 63.77% <ø> (?)
ws 58.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/interactions/slashCommands/options/integer.ts 100.00% <0.00%> (ø)
...s/src/interactions/slashCommands/options/string.ts 100.00% <0.00%> (ø)
...ges/builders/src/interactions/modals/Assertions.ts 100.00% <0.00%> (ø)
packages/voice/src/networking/Networking.ts 3.18% <0.00%> (ø)
packages/builders/src/util/normalizeArray.ts 100.00% <0.00%> (ø)
.../src/interactions/slashCommands/options/boolean.ts 100.00% <0.00%> (ø)
...ixins/ApplicationCommandOptionChannelTypesMixin.ts 100.00% <0.00%> (ø)
packages/builders/src/interactions/modals/Modal.ts 100.00% <0.00%> (ø)
packages/voice/src/networking/VoiceUDPSocket.ts 90.47% <0.00%> (ø)
packages/voice/src/util/Secretbox.ts 33.33% <0.00%> (ø)
... and 64 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jiralite Jiralite removed the blocked label Dec 15, 2022
@almeidx almeidx force-pushed the discord.js/forum-default-layout branch from 7182711 to 43a5c40 Compare December 16, 2022 13:19
@kodiakhq kodiakhq bot merged commit cbafd47 into discordjs:main Dec 16, 2022
@almeidx almeidx deleted the discord.js/forum-default-layout branch December 16, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants