-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ForumChannel): add defaultForumLayout
#8895
Merged
kodiakhq
merged 2 commits into
discordjs:main
from
almeidx:discord.js/forum-default-layout
Dec 16, 2022
Merged
feat(ForumChannel): add defaultForumLayout
#8895
kodiakhq
merged 2 commits into
discordjs:main
from
almeidx:discord.js/forum-default-layout
Dec 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
December 1, 2022 16:40
Mateo-tem
suggested changes
Dec 1, 2022
packages/discord.js/src/managers/CategoryChannelChildManager.js
Outdated
Show resolved
Hide resolved
almeidx
force-pushed
the
discord.js/forum-default-layout
branch
from
December 15, 2022 15:47
9d0c53a
to
392e315
Compare
kyranet
approved these changes
Dec 15, 2022
Codecov Report
@@ Coverage Diff @@
## main #8895 +/- ##
==========================================
+ Coverage 77.66% 84.35% +6.69%
==========================================
Files 24 98 +74
Lines 3837 9180 +5343
Branches 348 1096 +748
==========================================
+ Hits 2980 7744 +4764
- Misses 853 1394 +541
- Partials 4 42 +38
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
iCrawl
approved these changes
Dec 16, 2022
SpaceEEC
approved these changes
Dec 16, 2022
almeidx
force-pushed
the
discord.js/forum-default-layout
branch
from
December 16, 2022 13:19
7182711
to
43a5c40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Upstream:
default_forum_layout
discord/discord-api-docs#5693Depends on:
default_forum_layout
discord-api-types#658Status and versioning classification: