Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ThreadChannel): reason as second parameter #9023

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Jan 7, 2023

Please describe the changes this PR makes and why it should be merged:
reason is improperly being passed here. It is the second parameter, not the first:

/**
* Edits this thread.
* @param {ThreadEditData} data The new data for this thread
* @param {string} [reason] Reason for editing this thread
* @returns {Promise<ThreadChannel>}
* @example
* // Edit a thread
* thread.edit({ name: 'new-thread' })
* .then(editedThread => console.log(editedThread))
* .catch(console.error);
*/
async edit(data, reason) {

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Jan 7, 2023

@Jiralite is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jan 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
discord-js ❌ Failed (Inspect) Jan 7, 2023 at 9:38AM (UTC)

@jaw0r3k

This comment was marked as off-topic.

@Jiralite
Copy link
Member Author

Jiralite commented Jan 7, 2023

isnt it braking change?

This is not a breaking change.

@iCrawl iCrawl merged commit a941cb6 into discordjs:v13 Jan 10, 2023
@Jiralite Jiralite deleted the fix/thread-reason branch January 10, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants