Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Minor forums cleanup #9033

Merged
merged 6 commits into from
Feb 17, 2023
Merged

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Jan 8, 2023

Please describe the changes this PR makes and why it should be merged:

  • GuildChannelResolvable had ForumChannel listed. This is redundant as GuildChannel already contains ForumChannel
  • ThreadChannel#setAppliedTags() documented a non-existent return type
  • ChannelFlags referenced BaseChannel which doesn't exist
  • threadName was documented and typed in webhook message editing instead of webhook message creation

Prettier wanted to modify the code for a while now which I've tried to prevent from happening as it would be a somewhat unrelated change, but it was getting frustrating.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Jan 8, 2023

@Jiralite is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jan 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
discord-js ❌ Failed (Inspect) Jan 13, 2023 at 4:06PM (UTC)

@SpaceEEC SpaceEEC merged commit eed293f into discordjs:v13 Feb 17, 2023
@Jiralite Jiralite deleted the fix/forum-cleanup branch February 17, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants