Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): http-only wrapper #9281

Merged
merged 1 commit into from
Apr 1, 2023
Merged

feat(core): http-only wrapper #9281

merged 1 commit into from
Apr 1, 2023

Conversation

iCrawl
Copy link
Member

@iCrawl iCrawl commented Mar 27, 2023

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

@vercel
Copy link

vercel bot commented Mar 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2023 11:35pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2023 11:35pm

@github-actions
Copy link

github-actions bot commented Mar 27, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟠 PWA 70

Lighthouse ran on https://discord-js-guide-git-feat-core-http-only-wrapper-discordjs.vercel.app/

@Jiralite Jiralite added this to the core 0.5.0 milestone Mar 27, 2023
@iCrawl iCrawl force-pushed the feat/core-http-only-wrapper branch from 6921c60 to c4b55b7 Compare April 1, 2023 23:34
@iCrawl iCrawl force-pushed the feat/core-http-only-wrapper branch from c4b55b7 to c2b61ce Compare April 1, 2023 23:35
@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #9281 (6921c60) into main (ab3328a) will increase coverage by 23.61%.
The diff coverage is n/a.

❗ Current head 6921c60 differs from pull request most recent head c2b61ce. Consider uploading reports for the commit c2b61ce to get more accurate results

@@             Coverage Diff             @@
##             main    #9281       +/-   ##
===========================================
+ Coverage   59.93%   83.54%   +23.61%     
===========================================
  Files         214      100      -114     
  Lines       13726     9574     -4152     
  Branches     1246     1103      -143     
===========================================
- Hits         8226     7999      -227     
+ Misses       5460     1535     -3925     
  Partials       40       40               
Flag Coverage Δ
guide ?
website ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 119 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@iCrawl iCrawl merged commit 11e682c into main Apr 1, 2023
5 checks passed
@iCrawl iCrawl deleted the feat/core-http-only-wrapper branch April 1, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants