Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(proxy): rely on auth header instead #9422

Merged
merged 6 commits into from
Apr 21, 2023
Merged

Conversation

didinele
Copy link
Member

@didinele didinele commented Apr 19, 2023

Please describe the changes this PR makes and why it should be merged:
This more or less acts as a fix for auth: false being completely disregarded by the proxy if a client were to use it, which can run us into the nasty 401 bug.

馃 Generated by Copilot at eb414a9

We are the proxy of doom, we forward the headers of fate
We don't need a token of lies, we break the chains of the gate
We handle the errors of wrath, we populate the response of hate
We fix the imports of death, we are the proxy of doom

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@didinele didinele added this to the proxy 1.5.0 milestone Apr 19, 2023
@didinele didinele requested a review from a team as a code owner April 19, 2023 15:02
@didinele didinele requested a review from iCrawl April 19, 2023 15:02
@vercel
Copy link

vercel bot commented Apr 19, 2023

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js 猬滐笍 Ignored (Inspect) Apr 21, 2023 7:19pm
discord-js-guide 猬滐笍 Ignored (Inspect) Apr 21, 2023 7:19pm

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #9422 (cc939c3) into main (a2ab2b8) will decrease coverage by 0.02%.
The diff coverage is 64.10%.

@@            Coverage Diff             @@
##             main    #9422      +/-   ##
==========================================
- Coverage   59.31%   59.29%   -0.02%     
==========================================
  Files         222      222              
  Lines       14611    14624      +13     
  Branches     1254     1257       +3     
==========================================
+ Hits         8666     8671       +5     
- Misses       5905     5913       +8     
  Partials       40       40              
Flag Coverage 螖
proxy 76.00% <64.10%> (-3.57%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
packages/proxy/src/util/responseHelpers.ts 81.70% <63.63%> (-8.46%) 猬囷笍
packages/proxy/src/handlers/proxyRequests.ts 77.04% <64.70%> (-1.22%) 猬囷笍

馃摚 We鈥檙e building smart automated test selection to slash your CI/CD build times. Learn more

packages/proxy-container/README.md Outdated Show resolved Hide resolved
@didinele didinele requested a review from kyranet April 20, 2023 06:43
packages/proxy-container/README.md Outdated Show resolved Hide resolved
@didinele didinele requested a review from ckohen April 20, 2023 11:18
didinele and others added 6 commits April 21, 2023 22:18
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: Aura Rom谩n <kyradiscord@gmail.com>
Co-authored-by: ckohen <chaikohen@gmail.com>
@didinele
Copy link
Member Author

sorry about that, sorta messed up a rebase.

@Jiralite Jiralite removed request for suneettipirneni and a team April 21, 2023 20:08
@kodiakhq kodiakhq bot merged commit a49ed0a into main Apr 21, 2023
@kodiakhq kodiakhq bot deleted the refactor/proxy-auth branch April 21, 2023 20:36
@Jiralite Jiralite modified the milestones: proxy 1.5.0, proxy 1.4.1 May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

7 participants