Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support new username system #9634

Merged
merged 10 commits into from Jul 8, 2023
Merged

feat: support new username system #9634

merged 10 commits into from Jul 8, 2023

Conversation

aiko-chan-ai
Copy link

@aiko-chan-ai aiko-chan-ai commented Jun 10, 2023 •
edited

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@vercel
Copy link

vercel bot commented Jun 10, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Jul 8, 2023 3:18pm
discord-js-guide ⬜️ Ignored (Inspect) Jul 8, 2023 3:18pm

@Jiralite Jiralite added this to the discord.js 13.17 milestone Jun 10, 2023
@Jiralite Jiralite changed the title feat: support new username system (v13) feat: support new username system Jun 10, 2023
jaw0r3k
jaw0r3k reviewed Jun 10, 2023
View reviewed changes
typings/index.d.ts Outdated Show resolved Hide resolved
@aiko-chan-ai @jaw0r3k
Update typings/index.d.ts
d73a28b 
Co-authored-by: Jaw0r3k <jaworekwiadomosci@gmail.com>
jaw0r3k
jaw0r3k reviewed Jun 10, 2023
View reviewed changes
src/util/Util.js Outdated Show resolved Hide resolved
@aiko-chan-ai @jaw0r3k
Update src/util/Util.js
0aed6c6 
Co-authored-by: Jaw0r3k <jaworekwiadomosci@gmail.com>
Syjalo
Syjalo suggested changes Jun 10, 2023
View reviewed changes
typings/index.d.ts Show resolved Hide resolved
@Wissididom Wissididom mentioned this pull request Jun 12, 2023
Closed
@Jiralite
Copy link
Member

Jiralite commented Jul 8, 2023

Mind backporting #9660 too?

@Jiralite Jiralite self-requested a review July 8, 2023 00:51
Jiralite
Jiralite requested changes Jul 8, 2023
View reviewed changes
src/structures/User.js Outdated Show resolved Hide resolved
@Jiralite Jiralite removed the blocked label Jul 8, 2023
@kodiakhq kodiakhq bot merged commit f9e9843 into discordjs:v13 Jul 8, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaw0r3k jaw0r3k jaw0r3k left review comments

@Syjalo Syjalo Syjalo requested changes

@vladfrangu vladfrangu vladfrangu approved these changes

@kyranet kyranet kyranet approved these changes

@Jiralite Jiralite Jiralite approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC

Assignees
No one assigned
Labels
api support backport packages:discord.js semver:minor
Projects
discord.js
Archived in project
Milestone
discord.js 13.17
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aiko-chan-ai @Jiralite @vladfrangu @kyranet @Syjalo @jaw0r3k