fix(TransformerGraph): Explicitly include input args for readable input cases instead of just for string input cases #9793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r string input cases. Change also ensures that constant arrays are passed by value instead of by reference, preventing them from accidentally being modified.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://discord-js-guide-git-fork-white-wolf-main-discordjs.vercel.app/ |
|
Running Lighthouse audit... |
Jiralite
changed the title
vladfrangu
approved these changes
Aug 21, 2023
amishshah
approved these changes
Aug 23, 2023
SpaceEEC
approved these changes
Aug 23, 2023
almeidx
pushed a commit
to almeidx/discord.js
that referenced
this pull request
Sep 24, 2023
…ut cases instead of just for string input cases (discordjs#9793) Explicitly add input args for readable input cases instead of just for string input cases. Change also ensures that constant arrays are passed by value instead of by reference, preventing them from accidentally being modified. Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Change also ensures that constant arrays are passed by value instead of by reference in
TransformerGraph.ts, preventing them from accidentally being modified (which was part of the issue).Fixes: #7232
Status and versioning classification: