Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cross package links again #9995

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Conversation

Qjuh
Copy link
Contributor

@Qjuh Qjuh commented Nov 23, 2023

Please describe the changes this PR makes and why it should be merged:

Links to other packages still were sometimes wrong, if the property or method was documented in the inheriting class while only being defined in the inherited class. For example cache in Managers.

Fixes #9982

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@Qjuh Qjuh requested a review from iCrawl as a code owner November 23, 2023 16:52
Copy link

vercel bot commented Nov 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2023 4:58pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2023 4:58pm

@iCrawl iCrawl merged commit bc2ecef into discordjs:main Nov 24, 2023
22 checks passed
@Qjuh Qjuh deleted the fix/cross-package-links2 branch December 4, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Cross package reference doesnt redirect to the other one
2 participants