Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): type parameters on methods and overloads #9998

Merged

Conversation

Qjuh
Copy link
Contributor

@Qjuh Qjuh commented Nov 24, 2023

Please describe the changes this PR makes and why it should be merged:

Adds the type parameter documentation on methods that have type parameters too.

Also fixes overloads other than the first one not having any documentation.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@Qjuh Qjuh requested a review from a team as a code owner November 24, 2023 20:04
Copy link

vercel bot commented Nov 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 10:31pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Nov 30, 2023 10:31pm

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (cbbbfb9) 58.79% compared to head (802dc9c) 58.75%.
Report is 1 commits behind head on main.

Files Patch % Lines
...rc/components/model/method/MethodDocumentation.tsx 0.00% 18 Missing ⚠️
apps/website/src/util/model.ts 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9998      +/-   ##
==========================================
- Coverage   58.79%   58.75%   -0.04%     
==========================================
  Files         240      240              
  Lines       17033    17044      +11     
  Branches     1240     1240              
==========================================
  Hits        10014    10014              
- Misses       6974     6985      +11     
  Partials       45       45              
Flag Coverage Δ
website 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iCrawl iCrawl merged commit 1ec2901 into discordjs:main Dec 1, 2023
22 checks passed
@Qjuh Qjuh deleted the fix/website-method-overload-docs-type-params branch December 4, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants