Fix type of ServerMemberDeleteEvent#user #730
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not a Member anymore - they left the server.
swarley
suggested changes
Jun 21, 2020
Co-authored-by: Matt Carey <matthew.b.carey@gmail.com>
|
This was merged (with changes) via shardlab/discordrb@6485963 in the new repo and released in v3.4.0 and can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ServerMemberDeleteEvent#useris inherited fromServerMemberEvent- there it says it returns aMember, which is wrong in the case ofServerMemberDeleteEvent: the user is not aMemberanymore, they left the server. I tried callingMembermethods on it in my bot and was getting confused why they wouldn't work - I think this PR would clear up the confusion for other people.Added
Documentation for
ServerMemberDeleteEvent#user- now it correctly says it returns aUser.Changed
Deprecated
Removed
Fixed