Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Trigger tests/linting only on master pushes #2

Merged
merged 1 commit into from Oct 7, 2020
Merged

Conversation

CvX
Copy link
Contributor

@CvX CvX commented Oct 7, 2020

Triggering builds on push to any branch meant that everything was run twice on new PRs. For example see: https://github.com/discourse/discourse-voting/pull/61/checks (10 checks instead of 5)

(future TODO: change it to main when the times comes 馃槂)

Triggering builds on push to any branch meant that everything was run twice on new PRs. For example see: https://github.com/discourse/discourse-voting/pull/61/checks (10 checks instead of 5)

(future TODO: change it to `main` when the times comes 馃槂)
@CvX CvX requested a review from justindirose October 7, 2020 11:07
Copy link

@eviltrout eviltrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

Copy link
Contributor

@justindirose justindirose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

@CvX CvX merged commit 0153f86 into master Oct 7, 2020
@CvX CvX deleted the no-double-build branch October 7, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants