DEV: Switch theme to use new addComposerToolbarPopupMenuOption api
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why this change? The new API is better and allows us to avoid modifying the composer service.
martin-brennan
approved these changes
Oct 6, 2023
|
Thank you for reviewing @martin-brennan 👍 |
tgxworld
added a commit
that referenced
this pull request
Oct 16, 2023
…on` api (#61)" This reverts commit d59dc7c. We have compatibility problems with themes and core right now: https://meta.discourse.org/t/-/282315/7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change?
The new API is better and allows us to avoid modifying the composer service.