FIX: Fully re-render ads when navigating between pages #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtaylorhq
force-pushed
the
re-render-ads
branch
from
d7505fd
to
66b46a4
Compare
davidtaylorhq
force-pushed
the
render-glimmer
branch
2 times, most recently
from
bf6210a
to
bed5d23
Compare
In the past, the ad plugin relied on two side-effects to achieve this behaviour:
1. Components being fully destroyed/rendered when navigating between pages. This stopped working when Discourse core moved to the more efficient 'loading slider' UI
2. The `listLoading` argument. This was an implementation detail of the old discovery routing infrastructure. Core recently overhauled this and removed the `listLoading` argument, because loading is now handled properly by the Ember router.
Instead of these two properties, we can use the `currentRoute` property of Ember's router service to trigger changes when navigating between pages. A common `{{#each` trick is used to fully destroy/re-render components even if the ad network is unchanged.
davidtaylorhq
force-pushed
the
re-render-ads
branch
from
66b46a4
to
a011f3d
Compare
awesomerobot
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, the ad plugin relied on two side-effects to achieve this behaviour:
Components being fully destroyed/rendered when navigating between pages. This stopped working when Discourse core moved to the more efficient 'loading slider' UI
The
listLoadingargument. This was an implementation detail of the old discovery routing infrastructure. Core recently overhauled this and removed thelistLoadingargument, because loading is now handled properly by the Ember router.Instead of these two properties, we can use the
currentRouteproperty of Ember's router service to trigger changes when navigating between pages. A common{{#eachtrick is used to fully destroy/re-render components even if the ad network is unchanged.