FIX: automatic bot titles missing sometime #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes 2 big issues: 1. No matter how hard you try, grounding anthropic title prompt is just too hard. This works around by only looking at the last sentence it returns and treating as title 2. Non English locales would be stuck with "generic" title, this ensures every bot message gets a title, using a custom field to track Also, slightly tunes some anthropic prompts.
xfalcox
reviewed
Aug 23, 2023
| @@ -254,6 +256,8 @@ def prompt_limit | |||
|
|
|||
| def title_prompt(post) | |||
| [build_message(bot_user.username, <<~TEXT)] | |||
| You are titlebot. Given a topic you will figure out a title. | |||
| You will never respond with anything but a topic title. | |||
There was a problem hiding this comment.
Anthropic docs suggest using XML-like tags for this, and in our experience it works nice. Something along the lines:
Put the suggested titles between <title> tags and then using Nokogiri to extract the title.
There was a problem hiding this comment.
interesting, will give it a shot ... I tried with something mega generic so it is LLM neutral, but maybe we need per LLM guidance here 👍
xfalcox
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 2 big issues:
No matter how hard you try, grounding anthropic title prompt
is just too hard. This works around by only looking at the last
sentence it returns and treating as title
Non English locales would be stuck with "generic" title, this
ensures every bot message gets a title, using a custom field to
track
Also, slightly tunes some anthropic prompts.