FIX: Context menu not appearing in Firefox #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some issues where the context menu would not appear in Firefox.
1.
event.targetIn Firefox,
event.target.activeElementdoes not exist, instead we need to useevent.target, however the issue is that in all other browsersevent.targetinside<textarea>elements points to the HTML DOM, not a specific element. In all other browsers we need to useevent.target.activeElementto point to the<textarea>To resolve this so that works on all browsers we use
document.activeElementand compare it withthis._dEditorInputto see if it is the same.2.
window.getSelection().toString()In Firefox,
window.getSelection().toString()will always result in an empty string. Due to this bug in Firefox, we instead useselectionStartandselectionEndto identify what is selected from thedocument.activeElement's value.This PR has been tested on Firefox, Chromium, and Safari to ensure all functionality works correctly.