FEATURE: include tag and category context in search #217
Conversation
Previous to this we just included title/body.. tags and category structure can be very critical for decision making.
(not its responsibility to test)
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
thanks @vinothkannans was thinking about this and there are some N+1s here ... not sure how easy it is to fix though ... its all in a background job and most of the time you are waiting for LLM, but maybe I should fix. |
|
|
||
| if SiteSetting.tagging_enabled | ||
| hidden_tags ||= DiscourseTagging.hidden_tag_names | ||
| # using map over pluck to avoid n+1 (assuming caller preloading) |
There was a problem hiding this comment.
Instead of assuming can we check whether the association is loaded or not? like post.topic.association(:tags).loaded?. And we can raise an error if it's not loaded.
There was a problem hiding this comment.
I think it is the responsibility of Search or SemanticSearch ... but maybe we can raise a warning in case this happens.
|
|
||
| if posts.blank? | ||
| { args: search_args, rows: [], instruction: "nothing was found, expand your search" } | ||
| else | ||
| format_results(posts, args: search_args) do |post| | ||
| { | ||
| category_names = [ | ||
| post.topic.category&.parent_category&.name, |
There was a problem hiding this comment.
I don't know how the search command is executed in the background. Will it cause n+1 in category and parent_category attributes too?
Previous to this we just included title/body.. tags and category
structure can be very critical for decision making.