Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: GPT4o support and better auditing #618

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

SamSaffron
Copy link
Member

  • Introduce new support for GPT4o (automation / bot / summary / helper)
  • Properly account for token counts on OpenAI models
  • Track feature that was used when generating AI completions

- Introduce new support for GPT4o (automation / bot / summary / helper)
- Properly account for token counts on OpenAI models
- Track feature that was used when generating AI completions
@nattsw
Copy link
Contributor

nattsw commented May 14, 2024

@SamSaffron looks like legit failures -

1) DiscourseAi::AiBot::Tools::SearchSettings#process can return more many settings with no descriptions if there are lots of hits
     Failure/Error: { name: strategy.display_name, value: strategy.model }
     
     NoMethodError:
       undefined method `display_name' for nil:NilClass
     # ./plugins/discourse-ai/lib/summarization/models/custom_llm.rb:8:in `display_name'

@SamSaffron
Copy link
Member Author

SamSaffron commented May 14, 2024 via email

we need better interfaces to control registration and de-registration
@SamSaffron SamSaffron merged commit 8eee689 into main May 14, 2024
5 checks passed
@SamSaffron SamSaffron deleted the open-ai-features branch May 14, 2024 03:28
romanrizzi added a commit that referenced this pull request May 28, 2024
romanrizzi added a commit that referenced this pull request May 28, 2024
romanrizzi added a commit that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants