DEV: Normalize reviewable actions #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drenmi
force-pushed
the
dev/normalize-reviewable-actions
branch
from
730328f
to
b6e7e16
Compare
Drenmi
commented
Feb 19, 2024
| @@ -4,4 +4,8 @@ | |||
|
|
|||
| class ReviewableAkismetPostSerializer < ReviewableSerializer | |||
| payload_attributes :post_cooked, :external_error | |||
|
|
|||
| def created_from_flag? | |||
There was a problem hiding this comment.
The only use for this is to determine whether we display the context question:
Is this X Y?
I think it's not a stretch to say that Akismet is flagging posts. WDYT?
There was a problem hiding this comment.
created_from_flag sounds weird? When are reviewables not created from flagging?
There was a problem hiding this comment.
There are some settings, IIRC. E.g. where new user first post needs review.
nattsw
reviewed
Feb 19, 2024
| @@ -10,31 +10,24 @@ def self.action_aliases | |||
| def build_actions(actions, guardian, _args) | |||
| return [] unless pending? | |||
|
|
|||
| agree = | |||
| agree_bundle = | |||
nattsw
previously approved these changes
Feb 19, 2024
nattsw
reviewed
Feb 19, 2024
| @@ -46,8 +46,11 @@ en: | |||
| types: | |||
| reviewable_akismet_post: | |||
| title: "Akismet Flagged Post" | |||
| noun: "post" | |||
There was a problem hiding this comment.
Curious, where is noun used?
There was a problem hiding this comment.
It is used to construct the context question, e.g.:
Is this post spam?
nattsw
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
Several pieces of feedback suggests that the review actions for posts flagged by Akismet are confusing. Since there is conceptually little difference between a post marked as spam by a human and a computer, this PR brings the options more in line with what we have for posts marked as spam in core.
Before
After