Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Display context question for Akismet flagged users #131

Merged
merged 1 commit into from Mar 25, 2024

Conversation

Drenmi
Copy link
Contributor

@Drenmi Drenmi commented Mar 25, 2024

What is this fix?

The context question is missing for reviewables where Akismet has marked a user profile as spam, causing the options to be ambiguous due to missing context.

This PR fixes that.

Before:

Screenshot 2024-03-25 at 4 28 47 PM

After:

Screenshot 2024-03-25 at 4 28 24 PM

Comment on lines +10 to +12
def created_from_flag?
true
end
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only use for this is to determine whether we display the context question:

Is this X Y?

I think it's not a stretch to say that Akismet is flagging posts. We gave the same treatment to Akismet flagged posts.

@Drenmi Drenmi merged commit 3ee82d4 into main Mar 25, 2024
3 checks passed
@Drenmi Drenmi deleted the fix/show-context-question-for-akismet-flagged-users branch March 25, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants