Added restrictions to show assigned tab
#103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 84dee81.
plugin.rb
Outdated
| add_to_class(:group, :can_show_assigned_tab?) do | ||
| users = User.joins("JOIN group_users gu on users.id=gu.user_id").where("gu.group_id=?", self.id) | ||
|
|
||
| users.each do |u| |
There was a problem hiding this comment.
There might be thousands of users here, so we can't afford to load them into memory and loop over them. We will need to write a single SQL query which does the check.
|
@davidtaylorhq The query worked awesomely😍, learned something new from this😅 |
|
Great! Glad it worked 😁 Looks like travis is failing on this. And also we should add an rspec check method to make sure the new query keeps working correctly in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.