Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: simplify markup to fix j/k highlighting #516

Merged
merged 1 commit into from Oct 20, 2023
Merged

UX: simplify markup to fix j/k highlighting #516

merged 1 commit into from Oct 20, 2023

Conversation

awesomerobot
Copy link
Member

This cleans up the markup a bit, so instead of a div as a table child we use the td and removes the internal wrapper. This fixes an issue with a double highlight while using j/k navigation highlighting caused by the nested td.

Before:

<div>
  <td>
   dropdown here
  </td
</div>  

Screenshot 2023-10-19 at 6 21 13 PM

After:

<td>
 dropdown here
</td

Screenshot 2023-10-19 at 6 18 05 PM

@tgxworld tgxworld merged commit 7fe45c8 into main Oct 20, 2023
5 checks passed
@tgxworld tgxworld deleted the highlight-fix branch October 20, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants