Hide tab #83
Merged
Hide tab #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 84dee81.
| @@ -3,6 +3,11 @@ export default Ember.Component.extend({ | |||
|
|
|||
| init() { | |||
| this._super(...arguments); | |||
| this.set("canAssign", this.currentUser && this.currentUser.can_assign); | |||
| this.set( | |||
| "canAssign", | |||
There was a problem hiding this comment.
We should rename this to "displayAssignTab" or something. Because it doesn't mean 'canAssign' any more
There was a problem hiding this comment.
Sure, ill rename this
| @@ -1,8 +1,8 @@ | |||
| {{#if canAssign}} | |||
| <ul class ='nav-pills'> | |||
| <li> | |||
| {{#link-to 'group.assignments' group}} | |||
| {{d-icon "user-plus" class="glyph"}}{{i18n 'discourse_assign.group_assignments'}}{{concat ' (' group.assignment_count concat ')'}} | |||
| {{#link-to "group.assignments" group.assignment_count}} | |||
There was a problem hiding this comment.
That seems a bit weird. Did you mean to change this? I don't see why we would want to pass the count into the link-to component?
There was a problem hiding this comment.
Yaa this was supposed to remove😅, i just added it to test something😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiding assignments-tab and assignment count to Everyone added in this PR