Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

FIX: Always run automations in background when triggered via API #232

Merged
merged 1 commit into from Nov 6, 2023

Conversation

s3lase
Copy link
Contributor

@s3lase s3lase commented Nov 6, 2023

Currently, long running automations lead to timeouts.

This change moves automation trigger to the background instead of running it in the web process.

Currently, long running automations lead to timeouts.

This change moves automation trigger to the background instead of running it
in the web process.
Copy link

@markvanlan markvanlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming the trigger! method is still used elsewhere

@jjaffeux
Copy link
Contributor

jjaffeux commented Nov 6, 2023

I'm assuming the trigger! method is still used elsewhere

https://github.com/search?q=repo%3Adiscourse%2Fdiscourse-automation%20trigger!&type=code

@s3lase
Copy link
Contributor Author

s3lase commented Nov 6, 2023

Thanks everyone!

@s3lase s3lase merged commit 6bba5a6 into main Nov 6, 2023
5 checks passed
@s3lase s3lase deleted the fix/background-api-automation-runs branch November 6, 2023 18:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
4 participants