Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

FEATURE: allows to unfollow direct message channel #402

Merged
merged 5 commits into from Jan 3, 2022

Conversation

jjaffeux
Copy link
Contributor

@jjaffeux jjaffeux commented Dec 30, 2021

Screenshot 2021-12-30 at 11 21 20

Kapture 2021-12-30 at 11 24 47

@markvanlan
Copy link
Contributor

So if you unfollow a channel because you don't want it in the list, when that user messages you, you'll never see it until you manually refollow the channel?

I think we should add a check in message creation, that checks if it's a DM channel, and ensures all members are following

@jjaffeux
Copy link
Contributor Author

So if you unfollow a channel because you don't want it in the list, when that user messages you, you'll never see it until you manually refollow the channel?

I think we should add a check in message creation, that checks if it's a DM channel, and ensures all members are following

Indeed good point thanks 👍

@jjaffeux
Copy link
Contributor Author

@markvanlan ok that should do it: c171be0

@jjaffeux
Copy link
Contributor Author

test failure is fixed in main

@jjaffeux jjaffeux force-pushed the unfollow-direct-message-channel branch from c171be0 to abe0ed2 Compare January 2, 2022 07:54
@jjaffeux jjaffeux requested a review from CvX January 3, 2022 12:20
Copy link
Contributor

@CvX CvX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚢

lib/direct_message_channel_creator.rb Outdated Show resolved Hide resolved
@jjaffeux jjaffeux merged commit db67aef into main Jan 3, 2022
@jjaffeux jjaffeux deleted the unfollow-direct-message-channel branch January 3, 2022 13:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants