This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
FIX: Make get channel by name work with chatable name #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not force all channels to have a name, so the route to get a channel by name needs to work with the chatable names as well (e.g. category.name and topic.fancy_title). Note that this does not take into account DM channels where getting them by name is kind of tricky. The chat transcript service currently converts the channel attribute (e.g. channel="Music Lounge") into a link using the channel title in the /chat/chat_channels/:title format. A better fit rather than the somewhat unreliable and tricky channel title would be perhaps to use a channel ID instead...but that does have its own issues for the transcript. We should discuss internally.
lis2
approved these changes
May 16, 2022
jjaffeux
approved these changes
May 16, 2022
martin-brennan
added a commit
that referenced
this pull request
May 16, 2022
We have run across various complications when trying to link to a channel by channel title (see /t/66638 and #857 for examples) so instead we are just going to add a channel ID to the chat quotes instead for easier linking. This commit also improves DM channel titles for chat quotes, which were not taken into account in the original design, but was later allowed in 1f10fc6.
martin-brennan
deleted the
issue/make-get-channel-by-name-work-with-nameless
branch
martin-brennan
added a commit
that referenced
this pull request
May 17, 2022
We have run across various complications when trying to link to a channel by channel title (see /t/66638 and #857 for examples) so instead we are just going to add a channel ID to the chat quotes instead for easier linking. This commit also improves DM channel titles for chat quotes, which were not taken into account in the original design, but was later allowed in 1f10fc6.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not force all channels to have a name, so the route
to get a channel by name needs to work with the chatable
names as well (e.g. category.name and topic.fancy_title).
Note that this does not take into account DM channels where
getting them by name is kind of tricky.
The chat transcript service currently converts the channel
attribute (e.g. channel="Music Lounge") into a link using the
channel title in the /chat/chat_channels/:title format. A better
fit rather than the somewhat unreliable and tricky channel
title would be perhaps to use a channel ID instead...but that
does have its own issues for the transcript. We should discuss
internally.