FIX: send single report PM to groups #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbattersby
commented
Mar 22, 2024
| @@ -2,30 +2,24 @@ | |||
|
|
|||
| module ::DiscourseDataExplorer | |||
| class ReportGenerator | |||
| def initialize(creator_user_id) | |||
There was a problem hiding this comment.
No longer needed as the PM is sent by the system user anyway.
dbattersby
commented
Mar 22, 2024
| return [] if recipients.empty? | ||
|
|
||
| creator = User.find_by(id: @creator_user_id) | ||
| return [] unless Guardian.new(creator).can_send_private_messages? |
There was a problem hiding this comment.
Not needed as the PM is sent by the system user.
dbattersby
force-pushed
the
send-single-report-pm-to-groups
branch
from
8b06b8f
to
fa976a4
Compare
dbattersby
force-pushed
the
send-single-report-pm-to-groups
branch
from
fa976a4
to
410ac93
Compare
jjaffeux
reviewed
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change here is that we now send a single PM to a group rather than individual PMs to each group member.
We are also now setting email recipients correctly as
target_emails, support was added for emails in this change.