Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Modernization and fixes #14

Merged
merged 4 commits into from
May 17, 2024
Merged

DEV: Modernization and fixes #14

merged 4 commits into from
May 17, 2024

Conversation

keegangeorge
Copy link
Member

This PR applies a few modernizations, fixes, and a small feature:

  • Converts modal to .gjs
  • Fixes regression where the incorrect class was used in the .scss causing styling not to be applied
  • Updates css based on new changes to plugin outlet locations component
  • Adds the ability to add custom links

This theme-component lacks specs, though not crucial since its only used in development, I will still be adding them later in a follow-up PR.

@keegangeorge
Copy link
Member Author

Thanks @CvX 🎉 I've applied those fixes :)

@keegangeorge keegangeorge requested a review from CvX May 17, 2024 16:23
@keegangeorge keegangeorge merged commit d11744c into main May 17, 2024
5 checks passed
@keegangeorge keegangeorge deleted the fixes branch May 17, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants