FIX: Show activation modal if identity is missing #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user's identity was missing if they had encryption enabled, but the current device was not activated. To make it easy to use, the user was prompted to activate the device when they navigated to an encrypted topic. This behavior changed when `getIdentity` started to return a rejected promise when user has no identity (it used to return an empty identity).
eviltrout
reviewed
Jul 27, 2021
They are actually Widget object, not Model objects.
The underscore meant the functions could be used only in tests.
udan11
force-pushed
the
show-activate-modal
branch
from
b9ffc04
to
3c19de3
Compare
eviltrout
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user's identity was missing if they had encryption enabled, but the
current device was not activated. To make it easy to use, the user was
prompted to activate the device when they navigated to an encrypted
topic. This behavior changed when
getIdentitystarted to return arejected promise when user has no identity (it used to return an empty
identity).