DEV: Use admin plugin show page for configuration #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relies on discourse/discourse#26707 from core TODO: Restyle the list page, delete any unnecessary route or template files
martin-brennan
changed the title
martin-brennan
changed the title
ZogStriP
approved these changes
May 2, 2024
|
Thanks @ZogStriP ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes Gamification to follow the adminPlugins.show route convention
from core, which we are changing all plugins to use instead of their own custom
routes for advanced configuration. This moves some routes and paths around,
and moves additional data for the admin leaderboards routes into
extrasonthe plugin show API call.
It also adds some CSS classes to the templates, and a system spec for the admin
leaderboard functionality.
The next PR will redesign the leaderboards list to follow convention,
and refactor into components rather than just using route controllers + templates.
Relies on discourse/discourse#26707 from core, specs
will not pass until this is merged