Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: Disable needs-love button on save #2

Merged
merged 4 commits into from Jan 25, 2022
Merged

DEV: Disable needs-love button on save #2

merged 4 commits into from Jan 25, 2022

Conversation

oblakeerickson
Copy link
Member

  • disable button after save
  • have new tag appear automatically
  • load tag from site settings
  • started adding rspec tests
  • show a modal popup if error saving

@oblakeerickson
DEV: Disable needs-love button on save
88bcf94 
- disable button after save
- have new tag appear automatically
- load tag from site settings
- started adding rspec tests
- show a modal popup if error saving
@oblakeerickson
DEV: Apply prettier fixes
49c7b30
@oblakeerickson
DEV: Cleanup based on pr feedback
3e6be5b 
- Made several cleanup items based on pr feedback
- Removed the refresh first post logic in js because PostRevisor is
  actually handling this.
@oblakeerickson
prettier
8d93acc
@oblakeerickson oblakeerickson merged commit aff1af6 into main Jan 25, 2022
@oblakeerickson oblakeerickson deleted the disable-button branch January 25, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgxworld tgxworld tgxworld left review comments

@lis2 lis2 lis2 approved these changes

@martin-brennan martin-brennan martin-brennan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@oblakeerickson @lis2 @martin-brennan @tgxworld