FIX: Appropriately assign values when fetching user details #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattsw
commented
Mar 21, 2024
| @@ -113,7 +113,8 @@ def json_walk(result, user_json, prop, custom_path: nil) | |||
| path = path.gsub(".[].", ".").gsub(".[", "[") | |||
| segments = parse_segments(path) | |||
| val = walk_path(user_json, segments) | |||
| result[prop] = val if val.present? | |||
| # [] should be nil, false should be false | |||
There was a problem hiding this comment.
There's already a test for the []->nil
it "can walk json and handle an empty array" do
CvX
approved these changes
Mar 21, 2024
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in a user json with
falsevalues, due to a||operator, the value incorrectly evaluates to the right hand side. This was causing an issue.e.g.
This PR fixes that and appropriately assigns
falseto the specified path for user details.