DEV: Fix invalid markup #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the preview mode is set to "inline" and the filename starts with a whitespace, open it in a new tab instead of ignoring the PDF.
eviltrout
approved these changes
Nov 5, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
W3 validator says:
The component currently appends the iFrame to the attachment
<a>tag, resulting in invalid markup. This PR fixes that by adding the iFrame tag after the attachment<a>tag.This PR also makes a small adjustment that makes it possible to override the display mode if it's set to "inline" on a per-file basis.
If the global theme setting is set to "inline" and the file starts with a whitespace, don't render it inline, and instead of ignoring it, make it open in a new tab on click.