FIX: Promise finally error for perspectiveSave #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-brennan
force-pushed
the
issue/fix-promise-finally-error
branch
from
9dfa0e9
to
270124d
Compare
SamSaffron
approved these changes
Jun 1, 2022
martin-brennan
force-pushed
the
issue/fix-promise-finally-error
branch
from
270124d
to
f6b750e
Compare
tgxworld
reviewed
Jun 1, 2022
martin-brennan
force-pushed
the
issue/fix-promise-finally-error
branch
2 times, most recently
from
3273472
to
14fc7d2
Compare
There are some cases when the .save() call within .perspectiveSave() would return null instead of a promise, causing an error. We return null sometimes in core from this function, so we just check whether the result is null or a promise and act accordingly. Also adds some tests and does some minor refactoring.
martin-brennan
force-pushed
the
issue/fix-promise-finally-error
branch
from
14fc7d2
to
5d997d7
Compare
tgxworld
added a commit
that referenced
this pull request
Jun 1, 2022
This reverts commit 9f597fa. We suspect this commit is causing our plugin JS tests to fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some cases when the .save() call within
.perspectiveSave() would return null instead of a promise,
causing an error. We return null sometimes in core from
this function, so we just check whether the result is null
or a promise and act accordingly.
Also adds some tests and does some minor refactoring.
c.f. https://meta.discourse.org/t/javascript-error-in-google-perspective-api-plugin/226732