FIX: Show small action posts when sorted by activity #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 'Sort by Activity' is using '?filter=activity', it causes the .posts-filtered-notice to show up empty.
ZogStriP
approved these changes
Sep 4, 2023
tgxworld
approved these changes
Sep 5, 2023
|
Thanks yall! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related meta topic: https://meta.discourse.org/t/whispers-and-small-action-posts-disappear-in-post-voting-topic/267567
The bug now is that in both Sort by "Votes" and Sort by "Activity", we are not showing small action posts when a topic is closed, archived, or an assignment.
This commit removes the filter when sorting by activity, since it is chronological and makes sense for small action posts to be in between votes.
Related:
There is still an outstanding bug where due to Sort by "Activity" being a
?filter=activity, when a topic is closed, the returning post stream is empty and doesn't update the topic. That will be fixed in a separate PR.