FEATURE: Export metric for highest sequence usage #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plugin already exports `postgres_highest_sequence`, but the value cannot be reliable used for alerts because it is not linked with the maximum value of the column that uses it. In other words, a sequence may be used with an `integer` or a `bigint` column, which have very different maximum values. The highest `last_value` reported may be cause of concern for an `integer` column because it is close to the limit, but not a problem for a `bigint` column.
nbianca
force-pushed
the
feature_export_metric
branch
from
fea3c8e
to
5b6bcda
Compare
|
As discussed internally, I don't think we should add this metric. It'll give us a false sense of security. Just because a sequence has been updated to bigint, does not mean it is safe for it to go beyond MAX_INT. Instead, we should maintain a list of columns which we have verified are safe for larger integers. To ensure those columns remain safe, we should start their sequences at values larger than MAX_INT in tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugin already exports
postgres_highest_sequence, but the value cannot be reliable used for alerts because it is not linked with the maximum value of the column that uses it.In other words, a sequence may be used with an
integeror abigintcolumn, which have very different maximum values. The highestlast_valuereported may be cause of concern for anintegercolumn because it is close to the limit, but not a problem for abigintcolumn.