FIX: missing reaction user for heart emoji breaks post mover #255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user reacts to a post it creates an entry for both the
discourse_reactions_reactions
anddiscourse_reactions_reaction_users
tables.However, when a post is liked using the ❤️ emoji it still creates a
discourse_reactions_reactions
entry but stores user data withinpost_actions
in core and doesn't create adiscourse_reactions_reaction_users
entry.This change adds an extra check to skip adding
DiscourseReactions::ReactionUser
data if none is found.The new test recreates the logic outlined above to assume that the post has a reaction and not the reaction user when it is liked, and should still work correctly.