DEV: Resolve a compatibility issue in core with CustomHtml component #54
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Naming is arguably the most challenging part. 🙂 Thanks, Penar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meta: https://meta.discourse.org/t/right-sidebar-blocks/231067/79?u=arkshine
Users have reported an issue with the
custom-htmloption and their footer disappearing.The theme component includes a
custom-htmltemplate, while the core also has acustom-htmlcomponent for displaying the custom footer HTML through thelayoutdynamic property (EDIT: there are others places). As a result, the theme's component overrides the layout.https://github.com/discourse/discourse/blob/main/app/assets/javascripts/discourse/app/components/custom-html.js
https://github.com/discourse/discourse/blob/main/app/assets/javascripts/discourse/app/templates/application.hbs#L97-L102
This PR renames the component and uses
block.internalNamefor the component name but keeps theblock.nameuntouched for compatibility.Hopefully, the changes make sense!