FIX: Allow wiki and post_type revisions on staff alias user post. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattsw
reviewed
Jan 24, 2022
| before do | ||
| SiteSetting.set(:staff_alias_allowed_groups, Group::AUTO_GROUPS[:staff].to_s) | ||
| SiteSetting.set(:staff_alias_username, 'staff_alias_user') | ||
| SiteSetting.set(:staff_alias_enabled, true) |
There was a problem hiding this comment.
Do we need to have tests that reset enabled or with varying site settings?
There was a problem hiding this comment.
Good point, I've added a test case that changes staff_alias_allowed_groups.
nattsw
approved these changes
Jan 24, 2022
tgxworld
force-pushed
the
allow_more_revision
branch
from
9c0fd8b
to
311cf13
Compare
Previously, a user that is allowed to post as a staff alias user would not be able to change the post type or wiki status of the post. This commit fixes that by automatically revising the post as the staff alias user if the user making the revision is allowed to post as a staff alias user.
tgxworld
force-pushed
the
allow_more_revision
branch
from
311cf13
to
ffb3700
Compare
|
Thank you for reviewing @nattsw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a user that is allowed to post as a staff alias user would
not be able to change the post type or wiki status of the post. This
commit fixes that by automatically revising the post as the staff alias
user if the user making the revision is allowed to post as a staff alias
user.