Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Ensure deletion of product upon confirmation #195

Merged
merged 4 commits into from Mar 13, 2024
Merged

FIX: Ensure deletion of product upon confirmation #195

merged 4 commits into from Mar 13, 2024

Conversation

nattsw
Copy link
Contributor

@nattsw nattsw commented Mar 13, 2024

Regression from #158, where we were passing in "product" instead of {{product}}.

This commit ensures that the product item is passed in when deleting the product.

Drenmi
Drenmi approved these changes Mar 13, 2024
View reviewed changes
Copy link

@Drenmi Drenmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-03-13 at 4 24 39 PM

@nattsw nattsw merged commit 0d28c9a into main Mar 13, 2024
5 checks passed
@nattsw nattsw deleted the fix-product-not-deleting branch March 13, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZogStriP ZogStriP ZogStriP approved these changes

@Drenmi Drenmi Drenmi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@nattsw @ZogStriP @Drenmi