-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icons for Views and Replies, and Last Activity date #13
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, can you run the linter as well?
} | ||
|
||
.d-icon { | ||
color: var(--love); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've regressed on the color for the heart icon, can we restore that? Or does it look poorly if its color is different from the other icons?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was on purpose, it indeed looks really stupid if it's the only colored icon. Sorry for not mentioning that explicitly.
I wasn't sure how to deal with this, remove it by default seemed the best idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, for what is worth I agree with the removal of the red color. Initially Topic Cards had only one icon, and having it red was ok. But in Topic List Thumbnails none of the icons deviates from gray, which makes sense, and this PR follows that consistency.
For what is worth, this is how the four icons looks like, and it looks very good imho:
I'm not sure why the linter failed in the Github action, it works for me locally? |
As discussed in https://meta.discourse.org/t/add-icons-for-views-and-replies-and-last-activity-date-in-topic-cards/312505 this PR adds icons for views, replies and last activity.