New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: avoid reclaiming un-reclaimable votes #175

Merged

renato merged 1 commit into main from avoid_some_vote_reclaiming

Dec 11, 2023

Contributor

renato commented Dec 8, 2023

We were triggering the vote_reclaim job on scenarios where votes shouldn't be reclaimed:

editing a closed/archived/deleted topic's tracked_topic_fields (title/archetype/tags) field while not changing the category_id
moving a closed/archived/deleted topic to a different, votes-enabled category
unarchiving a closed topic
opening an archived topic

Tests were also added covering these use cases.


          FIX: avoid reclaiming un-reclaimable votes

32b63a8

pmusaraj approved these changes

View reviewed changes

renato merged commit c1195c3 into main

7 checks passed

renato deleted the avoid_some_vote_reclaiming branch

December 11, 2023 15:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment