FIX: Fix for anon users visiting posts when the plugin is enabled

lib/discourse_translator/guardian_extension.rb

@@ -3,6 +3,7 @@ module DiscourseTranslator::GuardianExtension
   def user_group_allowed?
     authorized_groups = SiteSetting.restrict_translation_by_group.split("|").map(&:to_i)
 
+    return false if !current_user
     user_groups = current_user.groups.pluck :id
     authorized = authorized_groups.intersection user_groups
     !authorized.empty?

spec/lib/guardian_extension_spec.rb

@@ -23,5 +23,11 @@
 
       expect(guardian.user_group_allowed?).to eq(false)
     end
+
+    it "returns false when the user is not logged in" do
+      SiteSetting.restrict_translation_by_group = "not_in_the_list"
+      non_logged_guardian = Guardian.new
+      expect(non_logged_guardian.user_group_allowed?).to eq(false)
+    end
   end
 end

spec/serializers/post_serializer_spec.rb

@@ -4,51 +4,67 @@
 
 RSpec.describe PostSerializer do
   let(:post) { Fabricate(:post) }
-  let!(:user) do
-    user = Fabricate(:user, locale: "en")
-    user.group_users << Fabricate(:group_user, user: user, group: Group[:trust_level_1])
-    user
-  end
-  let(:serializer) { PostSerializer.new(post, scope: Guardian.new(user)) }
 
   before do
     SiteSetting.translator_enabled = true
     SiteSetting.queue_jobs = true
   end
 
   describe "#can_translate" do
-    describe "when user is in a allowlisted group"
-    before do
-      SiteSetting.restrict_translation_by_group =
-        "#{Group.find_by(name: user.groups.first.name).id}|not_in_the_list"
-    end
-    describe "when post detected lang does not match user's locale" do
-      before do
-        post.custom_fields[DiscourseTranslator::DETECTED_LANG_CUSTOM_FIELD] = "ja"
-        post.save
+    describe "logged in user" do
+      let(:user) do
+        user = Fabricate(:user, locale: "en")
+        user.group_users << Fabricate(:group_user, user: user, group: Group[:trust_level_1])
+        user
+      end
+      let(:serializer) { PostSerializer.new(post, scope: Guardian.new(user)) }
+
+      describe "when user is in a allowlisted group" do
+        before do
+          SiteSetting.restrict_translation_by_group =
+            "#{Group.find_by(name: user.groups.first.name).id}|not_in_the_list"
+        end
+        describe "when post detected lang does not match user's locale" do
+          before do
+            post.custom_fields[DiscourseTranslator::DETECTED_LANG_CUSTOM_FIELD] = "ja"
+            post.save
+          end
+
+          it { expect(serializer.can_translate).to eq(true) }
+        end
+
+        describe "when post detected lang matches user's locale" do
+          before do
+            post.custom_fields[DiscourseTranslator::DETECTED_LANG_CUSTOM_FIELD] = "en"
+            post.save
+          end
+          it { expect(serializer.can_translate).to eq(false) }
+        end
       end
+      describe "when user is not in a allowlisted group" do
+        before do
+          post.custom_fields[DiscourseTranslator::DETECTED_LANG_CUSTOM_FIELD] = "ja"
+          post.save
+          SiteSetting.restrict_translation_by_group = "not_in_the_list"
+        end
 
-      it { expect(serializer.can_translate).to eq(true) }
+        it "should not translate even if the post detected lang does not match the user's locale" do
+          expect(serializer.can_translate).to eq(false)
+        end
+      end
     end
 
-    describe "when post detected lang matches user's locale" do
+    describe "when user is not logged in" do
+      let(:serializer) { PostSerializer.new(post, scope: Guardian.new) }
       before do
-        post.custom_fields[DiscourseTranslator::DETECTED_LANG_CUSTOM_FIELD] = "en"
+        post.custom_fields[DiscourseTranslator::DETECTED_LANG_CUSTOM_FIELD] = "ja"
         post.save
+        SiteSetting.restrict_translation_by_group = "11|not_in_the_list"
       end
-      it { expect(serializer.can_translate).to eq(false) }
-    end
-  end
-
-  describe "when user is not in a allowlisted group" do
-    before do
-      post.custom_fields[DiscourseTranslator::DETECTED_LANG_CUSTOM_FIELD] = "ja"
-      post.save
-      SiteSetting.restrict_translation_by_group = "not_in_the_list"
-    end
 
-    it "should not translate even if the post detected lang does not match the user's locale" do
-      expect(serializer.can_translate).to eq(false)
+      it "should not translate" do
+        expect(serializer.can_translate).to eq(false)
+      end
     end
   end
 end