FIX: Skip translations for empty or small actions posts #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattsw
force-pushed
the
prevent-job-queue-when-empty
branch
from
ccfd831
to
9c3fe96
Compare
ZogStriP
approved these changes
May 3, 2024
|
Thank you @ZogStriP ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each time a post is getting serialized, we check if the post's language has already been detected or not. If it has, there are no real side effects, and if it hasn't, the plugin sends a request to the enabled translator to detect the post's language.
The problem happens when we have small actions posts with no raw and the job keeps getting queued endlessly. I considered adding some checks at Jobs::DetectTranslation, or
cluster_concurrency 1, so it doesn't re-trigger in the event some actions happen too quickly, but it might seem unnecessary. We'll see.This PR prevents us from sending the post for language detection.
(There will be another PR to handle Amazon's errors due to misconfiguration)