FIX: Requests were not being logged correctly

`enable` was defaulting to `nil` which is not what we wanted.
discourse · May 20, 2020 · 096eca0 · 096eca0 · discoursebot · May 20, 2020
1 parent e1bd570
commit 096eca0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/app/models/application_request.rb b/app/models/application_request.rb
@@ -16,15 +16,16 @@ class ApplicationRequest < ActiveRecord::Base
   include CachedCounting
 
   def self.disable
-    @enabled = false
+    @disabled = true
   end
 
   def self.enable
-    @enabled = true
+    @disabled = false
   end
 
   def self.increment!(type, opts = nil)
-    perform_increment!(redis_key(type), opts) if @enabled
+    return if @disabled
+    perform_increment!(redis_key(type), opts)
   end
 
   def self.write_cache!(date = nil)

diff --git a/spec/rails_helper.rb b/spec/rails_helper.rb
@@ -128,6 +128,9 @@ def self.test_setup(x = nil)
     # code that runs inside jobs. run_later! means they are put on the redis
     # queue and never processed.
     Jobs.run_later!
+
+    # Don't track ApplicationRequests in test mode unless opted in
+    ApplicationRequest.disable
   end
 end