Skip to content

Commit

Permalink
DEV: Don't return navigation item from addNavigationBarItem
Browse files Browse the repository at this point in the history
No plugin or theme that I could find used the return value. Not
providing this to plugins affords us leeway to change the internals.
  • Loading branch information
danielwaterworth committed Nov 13, 2019
1 parent 58b5d14 commit 13c5381
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/assets/javascripts/discourse/lib/plugin-api.js.es6
Expand Up @@ -785,7 +785,7 @@ class PluginApi {
};
}

return addNavItem(item);
addNavItem(item);
}
}

Expand Down

0 comments on commit 13c5381

Please sign in to comment.