FIX: only add image size when with & height are in pixels

discourse · Jul 5, 2019 · 155cad8 · 155cad8
1 parent 589351d
commit 155cad8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/app/services/inline_uploads.rb b/app/services/inline_uploads.rb
@@ -220,10 +220,10 @@ def self.match_img(markdown, external_src: false)
 
       if src && (matched_uploads(src).present? || external_src)
         text = node.attributes["alt"]&.value
-        width = node.attributes["width"]&.value
-        height = node.attributes["height"]&.value
+        width = node.attributes["width"]&.value.to_i
+        height = node.attributes["height"]&.value.to_i
         title = node.attributes["title"]&.value
-        text = "#{text}|#{width}x#{height}" if width && height
+        text = "#{text}|#{width}x#{height}" if width > 0 && height > 0
         after_html_tag = match[0].present?
 
         spaces_before =

diff --git a/spec/services/inline_uploads_spec.rb b/spec/services/inline_uploads_spec.rb
@@ -267,6 +267,7 @@
         #{Discourse.base_url}#{upload3.url} #{Discourse.base_url}#{upload3.url}
 
         <img src="#{upload.url}" width="5" height="4">
+        <img src="#{upload.url}" width="5px" height="auto">
         MD
 
         expect(InlineUploads.process(md)).to eq(<<~MD)
@@ -283,6 +284,7 @@
         #{Discourse.base_url}#{upload3.short_path} #{Discourse.base_url}#{upload3.short_path}
 
         ![|5x4](#{upload.short_url})
+        ![](#{upload.short_url})
         MD
       end