DEV: Instantiate relation early to save a query (#14766)

Previously it would do `SELECT 1 AS one` and then `SELECT "color_scheme_colors".*`. Now it only does the latter.
discourse · Oct 29, 2021 · 19c9b89 · 19c9b89
1 parent b1603c8
commit 19c9b89
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/app/models/color_scheme.rb b/app/models/color_scheme.rb
@@ -346,7 +346,7 @@ def bump_version
   end
 
   def is_dark?
-    return if colors.empty?
+    return if colors.to_a.empty?
 
     primary_b = brightness(colors_by_name["primary"].hex)
     secondary_b = brightness(colors_by_name["secondary"].hex)