PERF: Avoid executing the same query twice.

discourse · May 13, 2020 · 34c39b6 · 34c39b6 · discoursereviewbot · May 13, 2020
1 parent 822e594
commit 34c39b6
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/app/models/topic_tracking_state.rb b/app/models/topic_tracking_state.rb
@@ -195,14 +195,16 @@ def self.report(user, topic_id = nil)
     #
     # This code needs to be VERY efficient as it is triggered via the message bus and may steal
     #  cycles from usual requests
+    tag_ids = muted_tag_ids(user)
+
     sql = +report_raw_sql(
       topic_id: topic_id,
       skip_unread: true,
       skip_order: true,
       staff: user.staff?,
       admin: user.admin?,
       user: user,
-      muted_tag_ids: muted_tag_ids(user)
+      muted_tag_ids: tag_ids
     )
 
     sql << "\nUNION ALL\n\n"
@@ -215,7 +217,7 @@ def self.report(user, topic_id = nil)
       filter_old_unread: true,
       admin: user.admin?,
       user: user,
-      muted_tag_ids: muted_tag_ids(user)
+      muted_tag_ids: tag_ids
     )
 
     DB.query(