FIX: local post onebox was always pointing to 1st post

discourse · Feb 26, 2018 · 3be0294 · 3be0294 · discoursebot · Feb 26, 2018
1 parent ac70169
commit 3be0294
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/lib/onebox/templates/discourse_topic_onebox.hbs b/lib/onebox/templates/discourse_topic_onebox.hbs
@@ -1,4 +1,4 @@
-<aside class='quote' data-post="1" data-topic="{{topic_id}}">
+<aside class='quote' data-post="{{post_number}}" data-topic="{{topic_id}}">
   <div class='title'>
     <div class='quote-controls'></div>
     {{{avatar}}}

diff --git a/lib/oneboxer.rb b/lib/oneboxer.rb
@@ -202,6 +202,7 @@ def self.local_topic_html(url, route, opts)
       else
         args = {
           topic_id: topic.id,
+          post_number: post.post_number,
           avatar: PrettyText.avatar_img(post.user.avatar_template, "tiny"),
           original_url: url,
           title: PrettyText.unescape_emoji(CGI::escapeHTML(topic.title)),

diff --git a/spec/components/oneboxer_spec.rb b/spec/components/oneboxer_spec.rb
@@ -54,6 +54,7 @@ def preview(url, user = nil, category = nil, topic = nil)
 
       onebox = preview(public_reply.url, user, public_category)
       expect(onebox).to include(public_reply.excerpt)
+      expect(onebox).to include(%{data-post="2"})
       expect(onebox).to include(PrettyText.avatar_img(replier.avatar_template, "tiny"))
 
       onebox = preview(public_reply.url, user, public_category, public_topic)